[webkit-reviews] review denied: [Bug 122422] JSC bindings generator should generate deletable JSC functions : [Attachment 213584] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 122422: JSC bindings generator should generate deletable JSC functions
https://bugs.webkit.org/show_bug.cgi?id=122422

Attachment 213584: Patch
https://bugs.webkit.org/attachment.cgi?id=213584&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Looks like this patch needs two things:

(1) The regression test should test overwriting, deleting, and enumerating DOM
properties, in addition to testing the return value of
getOwnPropertyDescriptor.

(2) The patch should make an opinionated decision about whether IDL functions
should be writeable, deletable, and/or enumerable. It seems like your opinion
is "yes", in which case, you should remove OperationsNotDeletable from IDL.

(3) Do any of these need to be marked [Unforgeable]? If so, the patch needs to
do that too, or it's a security regression.

There's no perfect way to assess the risk of (2), so I think we just need to
try it, and see what happens.