[webkit-reviews] review requested: [Bug 123945] Cosmetic: rename xxxId to xxxID for ScriptId, SourceId, and BreakpointId : [Attachment 216317] patch 2: changed some IDs to Identifiers in InspectorDebuggerAgent because those are meant to be strings.

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 123945: Cosmetic: rename xxxId to xxxID for ScriptId, SourceId, and
BreakpointId
https://bugs.webkit.org/show_bug.cgi?id=123945

Attachment 216317: patch 2: changed some IDs to Identifiers in
InspectorDebuggerAgent because those are meant to be strings.
https://bugs.webkit.org/attachment.cgi?id=216317&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
There are some places where ScriptID or SourceID is a string.  I chose to keep
those as "ID"s because they ultimately hold a numeric SourceID value, but just
happened to be encoded in a string.  In contrast, the InspectorDebuggerAgent
actually has a different representation of breakpoint ids which are string
names.	I renamed the "ID"s here to "Identifier".

As a reminder, this patch is meant to reduce the cosmetic changes that will
come with https://bugs.webkit.org/show_bug.cgi?id=121796.  With
https://bugs.webkit.org/show_bug.cgi?id=121796, all the SourceIDs and
BreakpointIDs in JSC and in the ScriptDebugServer will be numeric.  This
current patch makes use of that knowledge in choosing whether to use "ID" or
"Identifier" in the names.