[webkit-reviews] review granted: [Bug 123810] Avoid invalid cairo matrix when drawing surfaces too small : [Attachment 216184] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Cidorvan Leite
<cidorvan.leite at openbossa.org>'s request for review:
Bug 123810: Avoid invalid cairo matrix when drawing surfaces too small
https://bugs.webkit.org/show_bug.cgi?id=123810

Attachment 216184: Patch
https://bugs.webkit.org/attachment.cgi?id=216184&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=216184&action=review


Thanks! One small nit in the patch.

> Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp:164
>      FloatRect srcRect = originalSrcRect;
>  
> +    // Avoid invalid cairo matrix with small values.
> +    if (std::fabs(destRect.width()) < 0.5f || std::fabs(destRect.height()) <
0.5f)
> +	   return;
> +

Please move this above the definition of srcRect, as srcRect is only used
afterward.