[webkit-reviews] review granted: [Bug 120769] [CSS Regions] Selection focusNode set to the "region" block, instead of the "source" block : [Attachment 215498] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 7 09:38:04 PST 2013


Dave Hyatt <hyatt at apple.com> has granted Javier Fernandez
<jfernandez at igalia.com>'s request for review:
Bug 120769: [CSS Regions] Selection focusNode set to the "region" block,
instead of the "source" block
https://bugs.webkit.org/show_bug.cgi?id=120769

Attachment 215498: Patch
https://bugs.webkit.org/attachment.cgi?id=215498&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
r=me. 

Don't much like this bit though:

if (isRenderNamedFlowFragmentContainer())
   
toRenderBlockFlow(this)->renderNamedFlowFragment()->positionForPoint(point);

Can't just subclass positionForPoint?


More information about the webkit-reviews mailing list