[webkit-reviews] review canceled: [Bug 123981] [GTK] Move baselines after r158742 into proper place : [Attachment 216282] patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has canceled  review:
Bug 123981: [GTK] Move baselines after r158742 into proper place
https://bugs.webkit.org/show_bug.cgi?id=123981

Attachment 216282: patch
https://bugs.webkit.org/attachment.cgi?id=216282&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
(In reply to comment #3)
> (From update of attachment 216282 [details])
> Hmm.. it seems the quilty commit was r158810, as a result of running
"webkit-?
> patch optimize-baselines accessibility". Setting cq- for not, need to double 

> check this better...

It was a bit confusing but after some investigation I understand what happened:
the "optimize baselines" command just move expectations around to make their
storage more efficient but, unluckily enough, those two tests related two
tables also got at almost the same time in the state of "needing rebaseline".

So that's why they were failing in the bots: not because of their wrong
location but because neither the expectations in gtk-wk1/ nor the ones in
gtk-wk2/ were correct at this point. Fortunately, they are correct anyway and,
even better, exactly the same among the two versions of the port, so the right
solution is to generate new expectations, place them together under gtk/ again
and remove the specific ones we used to have in gtk-wk2.

So, clearing flags for now