[webkit-reviews] review requested: [Bug 117729] [ATK] Missing aria roles mappings. : [Attachment 216289] Patch set #9 - to be discussed

[bugzilla-daemon at webkit.org]

Lukasz Gajowy <l.gajowy at samsung.com> has asked	for review:
Bug 117729: [ATK] Missing aria roles mappings.
https://bugs.webkit.org/show_bug.cgi?id=117729

Attachment 216289: Patch set #9 - to be discussed
https://bugs.webkit.org/attachment.cgi?id=216289&action=review

------- Additional Comments from Lukasz Gajowy <l.gajowy at samsung.com>
I fixed it as you proposed... but:
I don't know how to test the WebAreaRole mapping. This is not a a role that is
invoked explicitly by writing the test: <div role="foobar">foobar role</div>
How can i test it different way? Should I test it?
The second thing is that document role and article role both are mapped to
ATK_ROLE_DOCUMENT_FRAME and because of that they both return "AXDocument" in
test. Is this behavior correct? "alert" and "alertdialog" roles seem to behave
similarly.