[webkit-reviews] review granted: [Bug 123980] Use tighter InlineBox subtypes in some places. : [Attachment 216280] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 7 03:02:25 PST 2013


Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 123980: Use tighter InlineBox subtypes in some places.
https://bugs.webkit.org/show_bug.cgi?id=123980

Attachment 216280: Patch
https://bugs.webkit.org/attachment.cgi?id=216280&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=216280&action=review


> Source/WebCore/rendering/RenderBox.cpp:1984
> +	   box.removeFromParent();
> +	   delete &box;

Maybe box.removeFromParent() should return a unique_ptr.


More information about the webkit-reviews mailing list