[webkit-reviews] review granted: [Bug 123577] Web Inspector: CSS Regions: Removing a content node of a ContentFlow from the DOM will send a 0 nodeId : [Attachment 216248] Patch V1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 6 19:30:29 PST 2013


Timothy Hatcher <timothy at apple.com> has granted Alexandru Chiculita
<achicu at adobe.com>'s request for review:
Bug 123577: Web Inspector: CSS Regions: Removing a content node of a
ContentFlow from the DOM will send a 0 nodeId
https://bugs.webkit.org/show_bug.cgi?id=123577

Attachment 216248: Patch V1
https://bugs.webkit.org/attachment.cgi?id=216248&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216248&action=review


> Source/WebInspectorUI/UserInterface/ContentFlowTreeContentView.js:186
> -	   this._nodesMap.remove(event.data.node.id);
> +	   this._nodesMap.delete(event.data.node.id);

Opps, good catch.

> Source/WebInspectorUI/UserInterface/DOMTreeManager.js:43
> +    this._contentNodesToFlowsMap = new Map();

No () is our style.


More information about the webkit-reviews mailing list