[webkit-reviews] review granted: [Bug 123941] kTraceBufferLen is unused in default builds : [Attachment 216249] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 6 17:29:17 PST 2013


Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 123941: kTraceBufferLen is unused in default builds
https://bugs.webkit.org/show_bug.cgi?id=123941

Attachment 216249: Patch
https://bugs.webkit.org/attachment.cgi?id=216249&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216249&action=review


Much better.

> Source/ThirdParty/ANGLE/src/compiler/debug.cpp:46
> +#if defined(__clang__)
> +#pragma clang diagnostic pop
> +#endif

This should wrap just the constant.


More information about the webkit-reviews mailing list