[webkit-reviews] review denied: [Bug 123828] AX: .js dialogs shown in unload while AX is running crash WebKit. : [Attachment 216211] Updated patch.

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Samuel White
<samuel_white at apple.com>'s request for review:
Bug 123828: AX: .js dialogs shown in unload while AX is running crash WebKit.
https://bugs.webkit.org/show_bug.cgi?id=123828

Attachment 216211: Updated patch.
https://bugs.webkit.org/attachment.cgi?id=216211&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
The tests are likely genuinely broken by this patch, they aren't flaky. So, r-
for breaking the tests.

More generally speaking, adding more state to DocumentLoader would be super
unfortunate, it already has too much state.

Could you please explain in more detail what is going wrong when the crash
occurs? Is there a stack trace for it?

If this is a regression, what patch did it regress with? I'm not even sure if
<rdar://problem/15160412> is the correct bug, its description is quite
different.