[webkit-reviews] review granted: [Bug 123930] Move allowed classes handling to decodeObject : [Attachment 216227] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 6 14:57:35 PST 2013
Andreas Kling <akling at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 123930: Move allowed classes handling to decodeObject
https://bugs.webkit.org/show_bug.cgi?id=123930
Attachment 216227: Patch
https://bugs.webkit.org/attachment.cgi?id=216227&action=review
------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216227&action=review
r=me
> Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm:453
> + if (!allowedClasses)
> + allowedClasses = decoder->_allowedClasses;
Not a fan of overwriting arguments like this. I like your IRC version better.
More information about the webkit-reviews
mailing list