[webkit-reviews] review granted: [Bug 123835] Support iteration of the Arguments object : [Attachment 216096] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 123835: Support iteration of the Arguments object
https://bugs.webkit.org/show_bug.cgi?id=123835

Attachment 216096: Patch
https://bugs.webkit.org/attachment.cgi?id=216096&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216096&action=review


r=me with comments addressed.

> Source/JavaScriptCore/runtime/CommonIdentifiers.h:31
>      macro(Array) \
> +    macro(ArgumentsIterator) \

Sort ArgumentsIterator before Array.

> LayoutTests/js/script-tests/arguments-iterator.js:57
> +function testStrict() {
> +    var i = 0;
> +    for (arg of arguments) {
> +	   realArg = arguments[i++];
> +	   shouldBeTrue("arg === realArg");
> +    }
> +    iteratedArgumentsLength = i;
> +    actualArgumentsLength = arguments.length;
> +    shouldBe("actualArgumentsLength", "iteratedArgumentsLength");
> +}
> +
> +testStrict();
> +testStrict("a");
> +testStrict("a", "b");
> +testStrict({})

What makes this test case "strict"?  It looks the identical to the non-strict
"test()" test case above.