[webkit-reviews] review granted: [Bug 123904] Add WKBrowsingContextPolicyDelegate : [Attachment 216197] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 123904: Add WKBrowsingContextPolicyDelegate
https://bugs.webkit.org/show_bug.cgi?id=123904

Attachment 216197: Patch
https://bugs.webkit.org/attachment.cgi?id=216197&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216197&action=review


> Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h:46
> + at property (assign) id<WKBrowsingContextLoadDelegate> loadDelegate;
> + at property (assign) id<WKBrowsingContextPolicyDelegate> policyDelegate;

Space after id

> Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm:608
> +		   WKActionIsMainFrameKey: WKFrameIsMainFrame(frame) ? @YES :
@NO,

Can just do @(WKFrameIsMainFrame(frame))

> Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm:624
> +		   WKActionIsMainFrameKey: WKFrameIsMainFrame(frame) ? @YES :
@NO,

Can just do @(WKFrameIsMainFrame(frame))

> Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h:36
> +extern NSString *WKActionIsMainFrameKey; // NSNumber (BOOL)
> +extern NSString *WKActionNavigationTypeKey; // NSNumber (WKNavigationType)
> +extern NSString *WKActionMouseButtonKey; // NSNumber (0 for left button, 1
for middle button, 2 for right button)
> +extern NSString *WKActionModifierFlagsKey; // NSNumber (unsigned)
> +extern NSString *WKActionURLRequestKey; // NSURLRequest
> +extern NSString *WKActionURLResponseKey; // NSURLResponse
> +extern NSString *WKActionFrameNameKey; // NSString

These should have headerdoc like documentation.