[webkit-reviews] review granted: [Bug 123380] JSExport doesn't support constructors : [Attachment 216193] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 6 11:14:21 PST 2013


Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 123380: JSExport doesn't support constructors
https://bugs.webkit.org/show_bug.cgi?id=123380

Attachment 216193: Patch
https://bugs.webkit.org/attachment.cgi?id=216193&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216193&action=review


r=me

> Source/JavaScriptCore/API/JSWrapperMap.mm:623
> +#if OS(DARWIN)

I think it's fair to assume that all ObjC OS's are DARWIN. So, you can remove
this #ifdef.


More information about the webkit-reviews mailing list