[webkit-reviews] review granted: [Bug 123879] Ended event should be triggered also when playback rate is negative : [Attachment 216149] Patch & layout test

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Piotr Grad
<p.grad at samsung.com>'s request for review:
Bug 123879: Ended event should be triggered also when playback rate is negative
https://bugs.webkit.org/show_bug.cgi?id=123879

Attachment 216149: Patch & layout test
https://bugs.webkit.org/attachment.cgi?id=216149&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216149&action=review


> LayoutTests/media/video-ended-event-negative-playback.html:17
> +		       function ()
> +		       {
> +			   video.currentTime = 2;
> +			   video.playbackRate = -1;
> +			   video.play();
> +			   failTestIn(2500);
> +		       });

This test will always take at least 2 seconds to complete.This seems excessive,
can you make it something like .5 instead?

> Source/WebCore/html/HTMLMediaElement.cpp:3679
>      double dur = duration();

Nit: can you please get rid of the "dur" abbreviation while you are here:
double duration = this->duration();