[webkit-reviews] review granted: [Bug 123899] [GTK] Use deprecation guards around deprecated API in GObject DOM bindings : [Attachment 216185] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 123899: [GTK] Use deprecation guards around deprecated API in GObject DOM
bindings
https://bugs.webkit.org/show_bug.cgi?id=123899

Attachment 216185: Patch
https://bugs.webkit.org/attachment.cgi?id=216185&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=216185&action=review


Looking good, with one small nit about the comment style.

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1009
> +	   push(@hBody, "#endif /* WEBKIT_DISABLE_DEPRECATED */\n");

See below.

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1234
> +	   push(@cBody, "#endif /* WEBKIT_DISABLE_DEPRECATED */\n");

See below.

> Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:167

> +#endif /* WEBKIT_DISABLE_DEPRECATED */

I think we typically use C++ style comments for this sort of thing.