[webkit-reviews] review denied: [Bug 99825] [ATK] accessibility/title-ui-element-correctness.html fails : [Attachment 216163] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 6 05:18:43 PST 2013


Mario Sanchez Prada <mario at webkit.org> has denied Michal Pakula vel Rutka
<m.pakula at samsung.com>'s request for review:
Bug 99825: [ATK] accessibility/title-ui-element-correctness.html fails
https://bugs.webkit.org/show_bug.cgi?id=99825

Attachment 216163: proposed patch
https://bugs.webkit.org/attachment.cgi?id=216163&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=216163&action=review


> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:194
> +static void removeAtkRelationFromRelationSetByType(AtkRelationSet*
relationSet, AtkRelationType relationType)

I think removeAtkRelationByType is enough for the name

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:199
> +	   if (atk_relation_get_relation_type(relation) ==
ATK_RELATION_LABELLED_BY) {

You should be comparing against your relationType parameter, not that hardcoded
case

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:201
> +	       break;

You should not break here, as the same type of AtkRelation might exist between
one base object and one or more target objects. So, if you are removing by type
you should remove them all the relationships matching that type


More information about the webkit-reviews mailing list