[webkit-reviews] review canceled: [Bug 123804] Manage ScriptExecutionContext::Task derivatives through std::unique_ptr : [Attachment 216048] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 5 23:55:50 PST 2013


Zan Dobersek <zandobersek at gmail.com> has canceled Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 123804: Manage ScriptExecutionContext::Task derivatives through
std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=123804

Attachment 216048: Patch
https://bugs.webkit.org/attachment.cgi?id=216048&action=review

------- Additional Comments from Zan Dobersek <zandobersek at gmail.com>
The Mac build failed due to a couple undefined references which extra explicit
template instantiations would fix. MSVC doesn't play ball with the
std::make_unique friend declarations though, so that won't be possible to use.

I'll update the patch with public constructors that std::make_unique won't have
problems accessing.


More information about the webkit-reviews mailing list