[webkit-reviews] review granted: [Bug 123808] [CSS Shapes][CSS Regions] Simplify shape-inside-on-multiple-regions-with-negative-shape-top.html : [Attachment 216049] Patch

[bugzilla-daemon at webkit.org]

Mihnea Ovidenie <mihnea at adobe.com> has granted Zoltan Horvath
<zoltan at webkit.org>'s request for review:
Bug 123808: [CSS Shapes][CSS Regions] Simplify
shape-inside-on-multiple-regions-with-negative-shape-top.html
https://bugs.webkit.org/show_bug.cgi?id=123808

Attachment 216049: Patch
https://bugs.webkit.org/attachment.cgi?id=216049&action=review

------- Additional Comments from Mihnea Ovidenie <mihnea at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216049&action=review


r=me with some nits, please take them into account before committing.

>
LayoutTests/fast/regions/shape-inside/shape-inside-on-multiple-regions-with-neg
ative-shape-top-expected.html:35
>  <p>Bug <a href="http://webkit.org/b/123103">123103</a>: [CSS Shapes][CSS
Regions] Don't apply shape-inside when we have multiple auto-height regions and
the height is not resolved</p>

This is a wrong link to the original bug -> i think you mean 123346

>
LayoutTests/fast/regions/shape-inside/shape-inside-on-multiple-regions-with-neg
ative-shape-top.html:32
>  <p>Bug <a href="http://webkit.org/b/123103">123103</a>: [CSS Shapes][CSS
Regions] Don't apply shape-inside when we have multiple auto-height regions and
the height is not resolved</p>

Again, change the link to the bug please: 123346