[webkit-reviews] review denied: [Bug 123158] [WK2] UserMediaClient support : [Attachment 215378] wk2 usermediaclient

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 5 15:43:59 PST 2013


Benjamin Poulain <benjamin at webkit.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 123158: [WK2] UserMediaClient support
https://bugs.webkit.org/show_bug.cgi?id=123158

Attachment 215378: wk2 usermediaclient
https://bugs.webkit.org/attachment.cgi?id=215378&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=215378&action=review


I think your code is in great shape. For me the biggest road block with this
iterations are:
-Generic API tests.
-You should have helpers for WebKitTestRunner to use this from LayoutTest (+
some layout tests). See TestController::setGeolocationPermission() for an
example.

I was originally against the public API, but I start to think it will be a
useful addition to everyone. What you need to do though is cross-platform
tests.

> Source/WebKit2/UIProcess/API/C/WKPage.h:224
> +typedef void
(*WKPageDecidePolicyForUserMediaPermissionRequestCallback)(WKPageRef page,
WKFrameRef frame, WKSecurityOriginRef origin, WKUserMediaPermissionRequestRef
permissionRequest, const void* clientInfo);

Maybe WKPageDecidePolicyForUserMediaCapturePermissionRequestCallback?

Ok, tell me if I am misunderstanding...but:


More information about the webkit-reviews mailing list