[webkit-reviews] review granted: [Bug 123788] GetById->GetByOffset and PutById->PutByOffset folding should mark haveStructures since it may result in structure transition watchpoints : [Attachment 216005] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 123788: GetById->GetByOffset and PutById->PutByOffset folding should mark
haveStructures since it may result in structure transition watchpoints
https://bugs.webkit.org/show_bug.cgi?id=123788

Attachment 216005: the patch
https://bugs.webkit.org/attachment.cgi?id=216005&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
r=me

The phrase "have structures" does not communicate this detail to me. I think by
"have" you mean "speculated about, in a way which is invalid after an operation
that clobbers the world". Maybe a better name would be
"hasStructureSpeculations" or "hasStructuresToClobber" or
"hasClobberableStructures".