[webkit-reviews] review granted: [Bug 123786] [WK2] Add a WebKit2 API for Geolocation's highAccuracy : [Attachment 216001] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 123786: [WK2] Add a WebKit2 API for Geolocation's highAccuracy
https://bugs.webkit.org/show_bug.cgi?id=123786

Attachment 216001: Patch
https://bugs.webkit.org/attachment.cgi?id=216001&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216001&action=review


> Source/WebKit2/UIProcess/WebGeolocationManagerProxy.cpp:101
> +	   m_provider.setEnableHighAccuracy(this, isHighAccuracyEnabled());
>	   m_provider.startUpdating(this);

Too bad we always have to send two messages here. Seems to me that we could
have startUpdating take the high accuracy boolean, and/or combine startUpdating
and setEnableHighAccuracy into a single message.