[webkit-reviews] review granted: [Bug 123791] [GStreamer] Playback rate is ommitted when seeking : [Attachment 216019] Patch & layout test

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Piotr Grad
<p.grad at samsung.com>'s request for review:
Bug 123791: [GStreamer] Playback rate is ommitted when seeking
https://bugs.webkit.org/show_bug.cgi?id=123791

Attachment 216019: Patch & layout test
https://bugs.webkit.org/attachment.cgi?id=216019&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216019&action=review


Looks good but I have some nits about the test. Can you please fix them?

> LayoutTests/media/video-seek-with-negative-playback.html:1
> +<video></video>

<video/>
It'd be good to make this a normal html file with the usual head and body too.

> LayoutTests/media/video-seek-with-negative-playback.html:8
> +	   function ()

The coding style is not very consistent about curly braces. Can the test be
refactored to avoid the nested waitForEvent()s?

> LayoutTests/media/video-seek-with-negative-playback.html:16
> +		       if ( lastTime == -1) {

empty space