[webkit-reviews] review granted: [Bug 123757] Open XHRs should not prevent page throttling : [Attachment 215956] Fix

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 123757: Open XHRs should not prevent page throttling
https://bugs.webkit.org/show_bug.cgi?id=123757

Attachment 215956: Fix
https://bugs.webkit.org/attachment.cgi?id=215956&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215956&action=review


Patch looks fine, but seems you missed call sites in the GTK and EFL ports.

> Source/WebCore/loader/ResourceLoaderOptions.h:82
> +    ResourceLoaderOptions(SendCallbackPolicy sendLoadCallbacks,
ContentSniffingPolicy sniffContent, DataBufferingPolicy dataBufferingPolicy,
StoredCredentials allowCredentials, ClientCredentialPolicy credentialPolicy,
SecurityCheckPolicy securityCheck, RequestOriginPolicy requestOriginPolicy,
RequestIsXMLHTTP requestIsXMLHTTP)

Good that this argument is an enum.

> Source/WebCore/loader/ResourceLoaderOptions.h:100
> +    RequestIsXMLHTTP requestIsXMLHTTP;

But seems to me this should be a bool.