[webkit-reviews] review granted: [Bug 123740] [webcore/html] remove extra header includes from cpp files. : [Attachment 215924] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 4 15:28:54 PST 2013


Darin Adler <darin at apple.com> has granted Santosh Mahto
<santosh.ma at samsung.com>'s request for review:
Bug 123740: [webcore/html] remove extra header includes from cpp files.
https://bugs.webkit.org/show_bug.cgi?id=123740

Attachment 215924: Patch
https://bugs.webkit.org/attachment.cgi?id=215924&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215924&action=review


> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:62
> -#include <runtime/Uint8ClampedArray.h>
>  

We’re leaving an extra blank line here that we should delete.

> Source/WebCore/html/shadow/MediaControlsApple.cpp:37
> -#if ENABLE(VIDEO_TRACK)
> -#include "TextTrackCue.h"
> -#endif
>  

We’re leaving an extra blank line here that we should delete.

> Source/WebCore/html/shadow/MediaControlsBlackBerry.cpp:41
> -#if ENABLE(VIDEO_TRACK)
> -#include "TextTrackCue.h"
> -#endif
>  

We’re leaving an extra blank line here that we should delete.

> Source/WebCore/html/shadow/MediaControlsGtk.cpp:34
> -#include "Chrome.h"
> -#include "MouseEvent.h"
>  

We’re leaving an extra blank line here that we should delete.


More information about the webkit-reviews mailing list