[webkit-reviews] review requested: [Bug 123642] Eliminate HostCall bit from JSC Stack CallerFrame : [Attachment 215942] Updated patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has asked  for review:
Bug 123642: Eliminate HostCall bit from JSC Stack CallerFrame
https://bugs.webkit.org/show_bug.cgi?id=123642

Attachment 215942: Updated patch
https://bugs.webkit.org/attachment.cgi?id=215942&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
(In reply to comment #7)
> I also think that all accessor functions other than
vmEntrySentinelCallerFrame() should ASSERT(!isVMEntrySentinel()).

I tried adding the ASSERT() to the various accessors and it resulted in many
crashes.  I appears that we don't have an order that we initialize fields in
the header.  Before the CodeBlock is set up for a normal frame, we could have a
random 1 value. 

All other suggested changes were made.