[webkit-reviews] review granted: [Bug 123725] Use RenderAncestorIterator in a couple of places. : [Attachment 215897] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 123725: Use RenderAncestorIterator in a couple of places.
https://bugs.webkit.org/show_bug.cgi?id=123725

Attachment 215897: Patch
https://bugs.webkit.org/attachment.cgi?id=215897&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=215897&action=review


> Source/WebCore/rendering/RenderRegion.cpp:405
> +    if (auto closestFlowThreadAncestor =
ancestorsOfType<RenderNamedFlowThread>(*this).first()) {
> +	   m_parentNamedFlowThread = &*closestFlowThreadAncestor;
> +	   // Do not take into account a region that links a flow with itself.
The dependency
> +	   // cannot change, so it is not worth adding it to the list.
> +	   if (m_flowThread == m_parentNamedFlowThread)
> +	       m_flowThread = nullptr;
> +    } else
> +	   m_parentNamedFlowThread = nullptr;
>  }

I would reverse the test and do early return in the else case.