[webkit-reviews] review granted: [Bug 123728] CSSPrimitiveValue color constructors should return PassRef. : [Attachment 215900] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 123728: CSSPrimitiveValue color constructors should return PassRef.
https://bugs.webkit.org/show_bug.cgi?id=123728

Attachment 215900: Patch
https://bugs.webkit.org/attachment.cgi?id=215900&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=215900&action=review


> Source/WebCore/css/CSSValuePool.cpp:82
> -    // Just wipe out the cache and start rebuilding if it gets too big.
> +    // Remove one entry at random if the cache grows too large.
>      const int maximumColorCacheSize = 512;
> -    if (m_colorValueCache.size() > maximumColorCacheSize)
> -	   m_colorValueCache.clear();
> +    if (m_colorValueCache.size() >= maximumColorCacheSize)
> +	   m_colorValueCache.remove(m_colorValueCache.begin());

Maybe the bug title should really be about this.