[webkit-reviews] review granted: [Bug 123721] HTMLTableRowsCollection is always rooted at a HTMLTableElement. : [Attachment 215893] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 4 00:36:40 PST 2013


Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 123721: HTMLTableRowsCollection is always rooted at a HTMLTableElement.
https://bugs.webkit.org/show_bug.cgi?id=123721

Attachment 215893: Patch
https://bugs.webkit.org/attachment.cgi?id=215893&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=215893&action=review


> Source/WebCore/html/HTMLTableRowsCollection.cpp:164
> +    return rowAfter(&const_cast<HTMLTableElement&>(tableElement()),
toHTMLTableRowElement(previous));

I like putting & or * inside the cast and casting to the final type.


More information about the webkit-reviews mailing list