[webkit-reviews] review granted: [Bug 122942] PingLoader objects unnecessarily pass through OwnPtr : [Attachment 215864] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 122942: PingLoader objects unnecessarily pass through OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=122942

Attachment 215864: Patch
https://bugs.webkit.org/attachment.cgi?id=215864&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215864&action=review


> Source/WebCore/loader/PingLoader.h:68
> +    static inline void createPingLoader(Frame* frame, ResourceRequest&
request)
> +    {
> +	   // No need to free the PingLoader object or manage it via a smart
pointer - it will kill itself as soon as it receives a response.
> +	   new PingLoader(frame, request);
> +    }

Since this is in the class definition, the inline keyword is unneeded.

Since this is only used in the .cpp file, it need not be in the class
definition. I can be in the .cpp file, and just be declared in the class
definition.