[webkit-reviews] review granted: [Bug 123699] [CSSRegions] Use auto keyword to clean-up for loops : [Attachment 215853] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 3 07:19:06 PST 2013


Anders Carlsson <andersca at apple.com> has granted Mihnea Ovidenie
<mihnea at adobe.com>'s request for review:
Bug 123699: [CSSRegions] Use auto keyword to clean-up for loops
https://bugs.webkit.org/show_bug.cgi?id=123699

Attachment 215853: Patch
https://bugs.webkit.org/attachment.cgi?id=215853&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215853&action=review


> Source/WebCore/rendering/RenderRegion.cpp:538
> +    for (auto iter = m_renderObjectRegionStyle.begin(), end =
m_renderObjectRegionStyle.end(); iter != end; ++iter) {

I think you should change the other loops to have the end iterator in a local
variable as well, since you're changing them anyway.


More information about the webkit-reviews mailing list