[webkit-reviews] review granted: [Bug 123669] Implement generateKey for HMAC and AES-CBC : [Attachment 215815] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 2 23:14:13 PDT 2013


mitz at webkit.org <mitz at webkit.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 123669: Implement generateKey for HMAC and AES-CBC
https://bugs.webkit.org/show_bug.cgi?id=123669

Attachment 215815: proposed patch
https://bugs.webkit.org/attachment.cgi?id=215815&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=215815&action=review


> Source/WebCore/crypto/keys/CryptoKeyHMAC.h:44
> +    // If lengthBytes is 0, recommended length is used, which is the size of
the associated hash function's block size.

Needs an article before “recommended”.


More information about the webkit-reviews mailing list