[webkit-reviews] review granted: [Bug 123668] Fix UnicodeWchar after r157330. : [Attachment 215811] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 123668: Fix UnicodeWchar after r157330.
https://bugs.webkit.org/show_bug.cgi?id=123668

Attachment 215811: Patch
https://bugs.webkit.org/attachment.cgi?id=215811&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This looks fine. I’d like you to go further and move these functions into files
with the names of the ICU header files instead of UnicodeWchar.h/cpp, and put
them in a directory with some name like "FakeICU" or whatever we want to call
this minimal ICU-compatible shim you are using for WinCE.

This requires changes to the WinCE build system, which is why I didn’t do it.