[webkit-reviews] review granted: [Bug 123662] Add a child renderer iterator. : [Attachment 215825] More refined possible patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 123662: Add a child renderer iterator.
https://bugs.webkit.org/show_bug.cgi?id=123662

Attachment 215825: More refined possible patch
https://bugs.webkit.org/attachment.cgi?id=215825&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=215825&action=review


> Source/WebCore/rendering/RenderIterator.h:43
> +// Traversal helpers
> +
> +template <typename T, typename U>
> +inline T* firstChild(U& current)
> +{
> +    RenderObject* object = current.firstChild();
> +    while (object && !isRendererOfType<const T>(*object))
> +	   object = object->nextSibling();
> +    return static_cast<T*>(object);
> +}

I would move these below the class definitions.