[webkit-reviews] review granted: [Bug 123660] [Cocoa] Add WKNSDictionary : [Attachment 215802] Add WKNSDictionary

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 2 07:33:39 PDT 2013


Anders Carlsson <andersca at apple.com> has granted mitz at webkit.org
<mitz at webkit.org>'s request for review:
Bug 123660: [Cocoa] Add WKNSDictionary
https://bugs.webkit.org/show_bug.cgi?id=123660

Attachment 215802: Add WKNSDictionary
https://bugs.webkit.org/attachment.cgi?id=215802&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215802&action=review


> Source/WebKit2/Shared/Cocoa/WKNSDictionary.mm:48
> +// -initWithObjects:forKeys:count: not implemented, because it should never
be called.

In debug builds, could you add an implementation with an ASSERT_NOT_REACHED?


More information about the webkit-reviews mailing list