[webkit-reviews] review granted: [Bug 123648] Removing MediaStreamTrackVector and MediaStreamSourceVector typedefs : [Attachment 215781] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 1 18:03:58 PDT 2013
Eric Carlson <eric.carlson at apple.com> has granted Thiago de Barros Lacerda
<thiago.lacerda at openbossa.org>'s request for review:
Bug 123648: Removing MediaStreamTrackVector and MediaStreamSourceVector
typedefs
https://bugs.webkit.org/show_bug.cgi?id=123648
Attachment 215781: Patch
https://bugs.webkit.org/attachment.cgi?id=215781&action=review
------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215781&action=review
This looks good, thanks for doing it!
r=me, but it looks like it needs to be rebased so I listed a couple of drive-by
changes you might make.
> Source/WebCore/Modules/mediastream/MediaStream.cpp:137
> +void
MediaStream::cloneMediaStreamTrackVector(Vector<RefPtr<MediaStreamTrack>>&
destination, const Vector<RefPtr<MediaStreamTrack>>& origin)
Nit: while you are here, can you change "origin" to "source"?
> Source/WebCore/Modules/mediastream/MediaStream.cpp:219
> + for (Vector<RefPtr<MediaStreamTrack>>::iterator iter =
m_audioTracks.begin(); iter != m_audioTracks.end(); ++iter) {
Nit: while you are here, can you fix this to use "auto"?
> Source/WebCore/Modules/mediastream/MediaStream.cpp:226
> + for (Vector<RefPtr<MediaStreamTrack>>::iterator iter =
m_videoTracks.begin(); iter != m_videoTracks.end(); ++iter) {
Ditto.
> Source/WebCore/Modules/mediastream/MediaStream.cpp:236
> + for (Vector<RefPtr<MediaStreamTrack>>::iterator iter =
m_audioTracks.begin(); iter != m_audioTracks.end(); ++iter) {
Ditto.
> Source/WebCore/Modules/mediastream/MediaStream.cpp:241
> + for (Vector<RefPtr<MediaStreamTrack>>::iterator iter =
m_videoTracks.begin(); iter != m_videoTracks.end(); ++iter) {
Ditto.
> Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:169
> + for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = tracks.begin();
iter != tracks.end(); ++iter)
Ditto.
> Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:173
> + for (Vector<RefPtr<MediaStreamTrack>>::iterator iter = tracks.begin();
iter != tracks.end(); ++iter)
Ditto.
More information about the webkit-reviews
mailing list