[webkit-reviews] review granted: [Bug 123647] Add WebCrypto AES-CBC : [Attachment 215776] proposed patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 123647: Add WebCrypto AES-CBC
https://bugs.webkit.org/show_bug.cgi?id=123647

Attachment 215776: proposed patch
https://bugs.webkit.org/attachment.cgi?id=215776&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215776&action=review


>> Source/WebCore/bindings/js/JSCryptoAlgorithmDictionary.cpp:142
>> +	memcpy(result->iv,ivData.first, ivData.second);
> 
> Missing space after ,  [whitespace/comma] [3]

Missing space.

> Source/WebCore/bindings/js/JSCryptoAlgorithmDictionary.cpp:144
> +    return std::move(result);

Shouldn’t need to do std::move here.

> Source/WebCore/crypto/CryptoAlgorithmAesCbcParams.h:39
> +    char iv[16];

I’d just use a WTF FixedArray here.