[webkit-reviews] review granted: [Bug 123645] CSSAspectRatioValue construction helper should return PassRef. : [Attachment 215773] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 123645: CSSAspectRatioValue construction helper should return PassRef.
https://bugs.webkit.org/show_bug.cgi?id=123645

Attachment 215773: Patch
https://bugs.webkit.org/attachment.cgi?id=215773&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215773&action=review


> Source/WebCore/ChangeLog:8
> +	   No new tests (OOPS!).

OOPS!?

No file list?

> Source/WebCore/css/CSSAspectRatioValue.h:52
> +    explicit CSSAspectRatioValue(float numeratorValue, float
denominatorValue)

Two arguments -- no need for explicit, which only affects things with one
argument.