[webkit-reviews] review granted: [Bug 121806] Initial implementation of text-decoration-skip ink : [Attachment 215771] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 1 15:56:56 PDT 2013


Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 121806: Initial implementation of text-decoration-skip ink
https://bugs.webkit.org/show_bug.cgi?id=121806

Attachment 215771: Patch
https://bugs.webkit.org/attachment.cgi?id=215771&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215771&action=review


> Source/WebCore/rendering/InlineTextBox.cpp:1098
>	       context->drawLineForText(FloatPoint(localOrigin.x(),
localOrigin.y() + baseline + 1), width, isPrinting);

Missed the context-> here, otherwise looks ready to go.


More information about the webkit-reviews mailing list