[webkit-reviews] review granted: [Bug 123638] FTL should use a simple optimization pipeline by default : [Attachment 215764] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 123638: FTL should use a simple optimization pipeline by default
https://bugs.webkit.org/show_bug.cgi?id=123638

Attachment 215764: the patch
https://bugs.webkit.org/attachment.cgi?id=215764&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215764&action=review


r=me

> Source/JavaScriptCore/ftl/FTLCompile.cpp:271
> +	   llvm->AddPromoteMemoryToRegisterPass(modulePasses);

Shouldn't mem2reg always go first? (My understanding is that it's a simple
transformation that eliminates a lot of dummy code, and relies only on
convention and not on any other optimizations.)