[webkit-reviews] review granted: [Bug 121806] Initial implementation of text-decoration-skip ink : [Attachment 215761] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 1 14:29:53 PDT 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 121806: Initial implementation of text-decoration-skip ink
https://bugs.webkit.org/show_bug.cgi?id=121806

Attachment 215761: Patch
https://bugs.webkit.org/attachment.cgi?id=215761&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=215761&action=review


> Source/WebCore/rendering/InlineTextBox.cpp:809
> +static void populateWavyStrokeParameters(float strokeThickness, float&
controlPointDistance, float& step)

It's OK to use get now because you have out params.


More information about the webkit-reviews mailing list