[webkit-reviews] review granted: [Bug 123631] Begin work on encoding argument types : [Attachment 215754] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 1 13:49:10 PDT 2013


mitz at webkit.org <mitz at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 123631: Begin work on encoding argument types
https://bugs.webkit.org/show_bug.cgi?id=123631

Attachment 215754: Patch
https://bugs.webkit.org/attachment.cgi?id=215754&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=215754&action=review


> Source/WebKit2/ChangeLog:13
> +	   Add new helper function that encodes an object and returns the
dictionary.

s/function/method/

> Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm:98
> +	   // Should always self and _cmd.

Should always what self and _cmd?


More information about the webkit-reviews mailing list