[webkit-reviews] review requested: [Bug 123619] Move duplicate code in TrackPrivate classes to a common base class : [Attachment 215735] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 1 10:20:54 PDT 2013


Brendan Long <b.long at cablelabs.com> has asked  for review:
Bug 123619: Move duplicate code in TrackPrivate classes to a common base class
https://bugs.webkit.org/show_bug.cgi?id=123619

Attachment 215735: Patch
https://bugs.webkit.org/attachment.cgi?id=215735&action=review

------- Additional Comments from Brendan Long <b.long at cablelabs.com>
Question: Was it correct to move the `WTF_MAKE_NONCOPYABLE(VideoTrackPrivate);
WTF_MAKE_FAST_ALLOCATED;` to TrackPrivateBase, or does that need to stay in the
derived classes?


More information about the webkit-reviews mailing list