[webkit-reviews] review canceled: [Bug 112905] Nit: Cleanup casts in XSSAuditorDelegate::didBlockScript. : [Attachment 195534] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has canceled Mike West
<mkwst at chromium.org>'s request for review:
Bug 112905: Nit: Cleanup casts in XSSAuditorDelegate::didBlockScript.
https://bugs.webkit.org/show_bug.cgi?id=112905

Attachment 195534: Patch
https://bugs.webkit.org/attachment.cgi?id=195534&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195534&action=review


I think this is probably okay, but I'd like clarification before we commit
this.

> Source/WebCore/ChangeLog:16
> +	       pass in 'String()' explicitly. We can also drop the String()
cast

Is this really the same thing?	Wouldn't the String produced by blankURL be a
string containing the "about:blank" characters?  Does scheduleLocationChange
treat this identically to a blank string?

> Source/WebCore/html/parser/XSSAuditorDelegate.cpp:114
> +	  
m_document->frame()->navigationScheduler()->scheduleLocationChange(m_document->
securityOrigin(), "data:text/html,<p></p>", String());

So you are saying that String() in this context will behave the same as the
"about:blank" behavior of blankURL()?