[webkit-reviews] review granted: [Bug 117064] [WIN]Move "OleGetClipboard" to Pasteboard::createForCopyAndPaste. : [Attachment 203425] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 31 22:40:23 PDT 2013


Brent Fulgham <bfulgham at webkit.org> has granted huangxueqing
<huangxueqing at baidu.com>'s request for review:
Bug 117064: [WIN]Move "OleGetClipboard" to Pasteboard::createForCopyAndPaste.
https://bugs.webkit.org/show_bug.cgi?id=117064

Attachment 203425: patch
https://bugs.webkit.org/attachment.cgi?id=203425&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203425&action=review


This patch looks like a nice step in the right direction.  Please add a little
context in the ChangeLog so someone reading that file will have a better idea
what this change was for.

> Source/WebCore/ChangeLog:11
> +	   (WebCore::Editor::newGeneralClipboard):

Please add a note here describing what is changed.

> Source/WebCore/ChangeLog:13
> +	   (WebCore::Pasteboard::createForCopyAndPaste):

Ditto.


More information about the webkit-reviews mailing list