[webkit-reviews] review granted: [Bug 117090] Need the ability to get the information for a plug-in with a particular process id that may be running on a page : [Attachment 203465] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted  review:
Bug 117090: Need the ability to get the information for a plug-in with a
particular process id that may be running on a page
https://bugs.webkit.org/show_bug.cgi?id=117090

Attachment 203465: Patch
https://bugs.webkit.org/attachment.cgi?id=203465&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203465&action=review


> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:496
> +    if (!pluginProcessProxy) {
> +	   callback->invalidate();
> +	   return;
> +    }

I think this can be an assertion.

> Source/WebKit2/WebProcess/WebPage/WebPage.h:354
> +    void containsPlugInsWithProcessToken(uint64_t plugInProcessToken,
uint64_t callbackID);

Maybe call this containsPluginViewsWithPluginProcessToken to match the other
two member functions.