[webkit-reviews] review denied: [Bug 117060] Made CodeType an enum class, and removed StackFrameCodeType. : [Attachment 203408] the patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 31 09:59:37 PDT 2013


Oliver Hunt <oliver at apple.com> has denied Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 117060: Made CodeType an enum class, and removed StackFrameCodeType.
https://bugs.webkit.org/show_bug.cgi?id=117060

Attachment 203408: the patch.
https://bugs.webkit.org/attachment.cgi?id=203408&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
While i appreciate the desire to have a single enum representing the code type
in a code block vs. in a stack frame, I don't think it is the right thing to do
as it means it will look like a CodeBlock could have "Native" or "Invalid" code
types which is clearly bogus.


More information about the webkit-reviews mailing list