[webkit-reviews] review requested: [Bug 114871] [GTK] Reimplement atk_text_get_text_*_offset for WORD boundaries : [Attachment 203426] Patch proposal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 31 02:36:25 PDT 2013


Mario Sanchez Prada <mario at webkit.org> has asked  for review:
Bug 114871: [GTK] Reimplement atk_text_get_text_*_offset for WORD boundaries
https://bugs.webkit.org/show_bug.cgi?id=114871

Attachment 203426: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=203426&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
Attaching a patch proposal to fix this. I've checked this idea with Accerciser
and Orca and seems to work fine. It also does not break any (layout or unit)
test and I even added some more cases to those to check edge cases we were not
checking previously (asking for "text before/after offset" for over the
first/last position).

Thus, kindly asking for review. If this patch gets in I'll work on the LINE
boundaries bug next :)


More information about the webkit-reviews mailing list