[webkit-reviews] review granted: [Bug 76935] [Windows] NRWT doesn't save crash logs on Apple's Windows port : [Attachment 203403] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 76935: [Windows] NRWT doesn't save crash logs on Apple's Windows port
https://bugs.webkit.org/show_bug.cgi?id=76935

Attachment 203403: Patch
https://bugs.webkit.org/attachment.cgi?id=203403&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203403&action=review


> Tools/Scripts/webkitpy/port/win.py:33
> +import subprocess

We shouldn't be importing this.

> Tools/Scripts/webkitpy/port/win.py:35
> +import tempfile

We shouldn't include this.

> Tools/Scripts/webkitpy/port/win.py:150
> +	   debugger_temp_directory = tempfile.mkdtemp()

Use filesystem.mkdtemp