[webkit-reviews] review denied: [Bug 117001] WebKit's Enter Full Screen for <video> elements isn't working : [Attachment 203372] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has denied Ruth Fong <ruthiecftg at gmail.com>'s
request for review:
Bug 117001: WebKit's Enter Full Screen for <video> elements isn't working
https://bugs.webkit.org/show_bug.cgi?id=117001

Attachment 203372: Patch
https://bugs.webkit.org/attachment.cgi?id=203372&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203372&action=review


> Source/WebCore/dom/Document.cpp:4980
> +    UserGestureIndicator indicator(DefinitelyProcessingNewUserGesture);
> +    

By inserting this UserGestureIndicator, this patch would disable the security
requirement that full screen requests must begin with an event handler.  The
appropriate place to put this line is in your context menu handler, immediately
before calling element->webkitRequestFullScreen(), not inside
requestFullScreenForElement() itself.